fix[faustwp]: (#1872) use home_url() in handle_generate_endpoint#2339
Open
latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
Open
fix[faustwp]: (#1872) use home_url() in handle_generate_endpoint#2339latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
Conversation
On Bedrock-style installs where WordPress core lives under /wp/,
site_url('/generate') returns https://example.com/wp/generate but
$_SERVER['REQUEST_URI'] is still /generate, so the preg_match in
handle_generate_endpoint() never fires and the auth-code redirect
silently breaks.
home_url() returns the public-facing URL (what REQUEST_URI actually
contains), which matches on both standard and Bedrock installs.
Per @josephfusco's guidance on wpengine#2315, which was closed in favor of
this simpler fix — a new filter is not needed, just the correct URL
helper.
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: c9b579f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Bedrock-style installs where WordPress core lives under
/wp/,site_url('/generate')returnshttps://example.com/wp/generatebut$_SERVER['REQUEST_URI']is still/generate. Thepreg_matchinhandle_generate_endpoint()never fires and the auth-code redirect silently breaks.home_url()returns the public-facing URL (whatREQUEST_URIactually contains), which matches on both standard and Bedrock installs.Related Issue
Closes #1872
Refiled per @josephfusco's guidance on #2315 — a new filter is not needed, just the correct URL helper.
Confirm the issue
Confirm the fix
Run the test suite
Checklist
canary@faustwp/wordpress-pluginpatch)